Skip to content

Comments

Fix neo_restart_this resetting game mode to CTG#1671

Merged
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom
Rainyan:bug/neo-restart-gamemode
Feb 23, 2026
Merged

Fix neo_restart_this resetting game mode to CTG#1671
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom
Rainyan:bug/neo-restart-gamemode

Conversation

@Rainyan
Copy link
Collaborator

@Rainyan Rainyan commented Feb 13, 2026

Description

Stop unconditionally calling GatherGameTypeVotes from CNEORules::RestartGame, because it was determining the game mode based on the players' "neo_vote_game_mode" userinfo cvar values, but this is inappropriate when the corresponding sv_neo_gamemode_enforcement mode is not set.

The mechanism itself also seems a bit obscure if the players are required to manually adjust their "neo_vote_game_mode" cvar values by console, but that stuff is out of scope for this PR.

Toolchain

  • Windows MSVC VS2022

Linked Issues

@Rainyan Rainyan requested a review from a team February 13, 2026 03:13
@AdamTadeusz AdamTadeusz requested a review from a team February 22, 2026 14:56
@Rainyan Rainyan merged commit 3d30f8b into NeotokyoRebuild:master Feb 23, 2026
7 checks passed
@Rainyan Rainyan deleted the bug/neo-restart-gamemode branch February 23, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doing neo_restart_this on a non CTG map causes the gamemode to change to CTG

3 participants