Use voice_modenable instead of voice_enable, fix voicerecord state#1703
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Feb 19, 2026
Merged
Conversation
…e bug `voice_enable` have issues when toggling it on/off and using the tweak in the settings menu, seems to be an Source SDK bug. However, I've noticed checked in HL2:DM, while it also have the same issue (through testing in console), the settings doesn't use `voice_enable` and now uses `voice_modenable` when it toggles that setting instead. Also added migration for v26 from voice_enable to voice_modenable setting. Then there's a second bug where after you fiddle around with tweaking, load up a local server and the voice recording HUD indicator in the bottom left show's it's recording even though it's actually not determining by voice_loopback 1. This can be worked around by setting UpdateSpeakerStatus and ending tweaking unified under the NeoSettingsEndVoiceTweakMode function. Extra note: When pressing the voice keybind, this will always re-enable voice_modenable to 1 and this is also the behavior on HL2:DM. So changing to this setting and this behavior is just in-parity with upstream's voice enable/disable behavior.
nullsystem
force-pushed
the
VoiceEnableLoopbackFix
branch
from
7ba421e to
64fb2a0
Compare
Masterkatze
approved these changes
Feb 18, 2026
Rainyan
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
voice_enablehave issues when toggling it on/off and using the tweak in the settings menu, seems to be an Source SDK bug. However, I've noticed checked in HL2:DM, while it also have the same issue (through testing in console), the settings doesn't usevoice_enableand now usesvoice_modenablewhen it toggles that setting instead.Also added migration for v26 from voice_enable to voice_modenable setting.
Then there's a second bug where after you fiddle around with tweaking, load up a local server and the voice recording HUD indicator in the bottom left show's it's recording even though it's actually not determining by voice_loopback 1. This can be worked around by setting UpdateSpeakerStatus and ending tweaking unified under the NeoSettingsEndVoiceTweakMode function.
Extra note: When pressing the voice keybind, this will always re-enable
voice_modenableto 1 and this is also the behavior on HL2:DM. So changing to this setting and this behavior is just in-parity with upstream's voice enable/disable behavior.Toolchain