Fix and guard against marker zero-length string showing random data#1728
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Feb 24, 2026
Merged
Conversation
The string wasn't zero-initalized, max length set 0 means it copies nothing and then it shows random data. Only an issue on Windows it seems but nevertheless need to have more checks to guard against this.
nullsystem
force-pushed
the
FixZeroLenMarkerStr
branch
from
a61332e to
1703f4c
Compare
Rainyan
approved these changes
Feb 24, 2026
sunzenshen
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The string wasn't zero-initalized, max length set 0 means it copies nothing and then it shows random data. Only an issue on Windows it seems but nevertheless need to have more checks to guard against this. Don't need to print text anyway if it's zero-length.
Toolchain