Fixup crosshair refactor logic issue#1798
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Mar 8, 2026
Merged
Conversation
Outline color should be dealt by if there's an outline or not, not by dot. Also make sure to reset to default settings before reading in crosshair serial.
nullsystem
force-pushed
the
fixupCrosshairRefactor
branch
from
1e7f7ce to
fcf3579
Compare
sunzenshen
approved these changes
Mar 8, 2026
Agiel
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline color should be dealt by if there's an outline or not, not by dot. Also make sure to reset to default settings before reading in crosshair serial.