Use the correct team icon in the new squad hud for nsf players whos class we don't know#1825
Merged
AdamTadeusz merged 5 commits intoNeotokyoRebuild:masterfrom Mar 12, 2026
Conversation
AdamTadeusz
added
the
Tournament Priority
AdamTadeusz
changed the title
AdamTadeusz
changed the title
Agiel
previously approved these changes
Mar 11, 2026
Contributor
Author
Whether the player is alive or dead has no effect on how far along the x axis we move. If we don't know what their class is we simply draw one of the two team icons at position 0 and 1 (we always know the class of players in our squad so the more detailed team icons will never show up). Otherwise we draw one of the class icons. |
Contributor
Author
|
Ok I added some comments as per your suggestion |
Agiel
approved these changes
Mar 11, 2026
sunzenshen
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.