Add toggle binds for duck and sprint#1889
Merged
Merged
Conversation
GetButtonCodeForBind returns the same code for both "+duck" and
"toggle_duck", which messes up the NeoUI bind display logic and has to
be handled separately.
To see the buggy behavior, comment out this commit and then:
- Bind "Duck (toggle)" to the same key as "Duck"
- This causes "Duck" to correctly un-bind because of the overlapping
bind
- Save changes & exit to NeoUI main menu
- Go back to NeoUI key binds options page
- See how "Duck" now incorrectly displays the "Duck (toggle)" bind
DESTROYGIRL
approved these changes
Apr 2, 2026
sunzenshen
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add keybinds for toggled (instead of held) duck and sprint inputs.
Toolchain
Linked Issues