Skip to content

Neo mp3 tweaks#1941

Merged
AdamTadeusz merged 19 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:354_neoMP3Tweaks
Apr 12, 2026
Merged

Neo mp3 tweaks#1941
AdamTadeusz merged 19 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:354_neoMP3Tweaks

Conversation

@AdamTadeusz
Copy link
Copy Markdown
Contributor

@AdamTadeusz AdamTadeusz commented Apr 11, 2026

Description

Moved the mp3 element left and down, element now moves up when joining the auto-queue
Removed the hamburger icon, song name instead can be clicked to select a song
Song name now scrolls if name of song too long to fit inside the mp3 player, with a 2 second delay
Right align song duration label
Progress slider doesn't ignore the first click if not active before click
Hovering over buttons in the mp3 player doesn't give off button hover sounds
Removed the second scrollbar visible to the right of the song selection popup scrollbar
Switched the play and pause "icons" around when music is playing/paused
Changed pause "icon" character to pipe

Toolchain

  • Windows MSVC VS2022

@AdamTadeusz AdamTadeusz marked this pull request as draft April 11, 2026 09:25
@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

Apparently miniaudio allows smooth volume transitions, but sadly I can't figure out how to get those to work.

@AdamTadeusz AdamTadeusz marked this pull request as ready for review April 11, 2026 11:32
@AdamTadeusz AdamTadeusz requested a review from a team April 11, 2026 11:32
Comment thread src/game/client/neo/ui/neo_ui.h
Comment thread src/game/client/neo/ui/neo_ui.h Outdated
Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
Comment thread src/game/client/neo/ui/neo_ui.h Outdated
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
@AdamTadeusz AdamTadeusz requested a review from nullsystem April 11, 2026 14:56
Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
@AdamTadeusz AdamTadeusz requested a review from nullsystem April 11, 2026 17:58
Comment thread src/game/client/neo/ui/neo_root.cpp Outdated
Copy link
Copy Markdown
Collaborator

@nullsystem nullsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup your commit message when you squash

@nullsystem nullsystem requested a review from a team April 11, 2026 18:56
@AdamTadeusz AdamTadeusz merged commit 437c89f into NeotokyoRebuild:master Apr 12, 2026
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 354_neoMP3Tweaks branch April 12, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants