Fix initial player tposing#570
Merged
AdamTadeusz merged 1 commit intoNeotokyoRebuild:masterfrom Sep 13, 2024
Merged
Conversation
brysondev
approved these changes
Sep 13, 2024
Masterkatze
approved these changes
Sep 13, 2024
Rainyan
added a commit
to Rainyan/rebuild
that referenced
this pull request
Sep 17, 2024
This reverts commit d209d44.
Rainyan
added a commit
to Rainyan/rebuild
that referenced
this pull request
Sep 18, 2024
Decouple `UpdateMuzzleFlashProperties` from BasePlayer, and move it to CNEO_Player shared implementation. For client side, use a `player_spawn` event listener for figuring out when the player spawns, instead of trying to capture it in-band from a networked "slot" command to the user. This fixes the bug that NeotokyoRebuild#570 attempted to address, (which will probably be reverted by NeotokyoRebuild#598, assuming it's accepted), and will remove the dependency to client side weapon switch for triggering `UpdateMuzzleFlashProperties` on player spawn.
Rainyan
added a commit
that referenced
this pull request
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace weapon_switch with ClientCommand
Toolchain
Linked Issues