Fix crash at Neo menu constructors#595
Merged
Rainyan merged 1 commit intoNeotokyoRebuild:masterfrom Sep 19, 2024
Merged
Conversation
Based on a crash dump. Can't safely call the virtual method here, so converting it to non-virtual. As we aren't overriding a function, and we're not being overridden, this shouldn't have an effect to other systems.
nullsystem
added
the
Release priority
nullsystem
approved these changes
Sep 18, 2024
AdamTadeusz
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on a crash dump. We can't safely call this virtual method from the constructor, so converting it to non-virtual. As we aren't overriding a function, and we're not being overridden, this shouldn't have any effect to other systems.
Toolchain
Linked Issues
None