Settings changed popup - Replace discard with cancel

[nullsystem]

Description

• Basically go back to settings instead, in which settings have a "Restore" button anyway

Toolchain

• Linux GCC Distro Native Arch/GCC 14

Linked Issues

• fixes [FEATURE] Cancel button in the Root Menu's Options #590

[Rainyan]

The "Restore" button in the settings menu should perhaps be renamed "Discard current changes" or similar - I assumed it would restore the defaults, but that does not appear to be the case. This could leave a user confused, where they cannot exit the menu because of pending changes, but they don't want to press the "Restore" button, fearing it'll override everything back to default instead of just discarding the pending changes.

It'd also be nice to have a "Restore defaults" button, but that's not strictly related.

[nullsystem]

The "Restore" button in the settings menu should perhaps be renamed "Discard current changes" or similar - I assumed it would restore the defaults, but that does not appear to be the case. This could leave a user confused, where they cannot exit the menu because of pending changes, but they don't want to press the "Restore" button, fearing it'll override everything back to default instead of just discarding the pending changes.

It'd also be nice to have a "Restore defaults" button, but that's not strictly related.

@Rainyan I would like to try to keep the button short though. Other alternatives like "Reset", "Discard", or "Cancel", although both "Discard"/"Cancel" does sound more like it'll also exit the settings page.

[xedmain]

The "Restore" button in the settings menu should perhaps be renamed "Discard current changes" or similar - I assumed it would restore the defaults, but that does not appear to be the case. This could leave a user confused, where they cannot exit the menu because of pending changes, but they don't want to press the "Restore" button, fearing it'll override everything back to default instead of just discarding the pending changes.
It'd also be nice to have a "Restore defaults" button, but that's not strictly related.

@Rainyan I would like to try to keep the button short though. Other alternatives like "Reset", "Discard", or "Cancel", although both "Discard"/"Cancel" does sound more like it'll also exit the settings page.

revert

[xedmain]

about confusing the user, that's why the discard button could be kept, because they may not notice the revert/restore button and will be stuck in the cancel loop or think they can only apply the settings or sth

[nullsystem]

@xedmain Alright discard back in now

[Rainyan]

LGTM.

I'm neutral on the "Discard" button for the popup, but the "Revert" wording is much clearer as to what the button does.