Skip to content

NeoUI - Console toggle key rebind, intended for non-` key layouts#636

Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom
nullsystem:GH-620_ConsoleJank
Sep 25, 2024
Merged

NeoUI - Console toggle key rebind, intended for non-` key layouts#636
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom
nullsystem:GH-620_ConsoleJank

Conversation

@nullsystem
Copy link
Copy Markdown
Collaborator

@nullsystem nullsystem commented Sep 22, 2024

Description

  • To workaround console not working for non-BACKQUOTE key layouts, allow the rebinding of the console to any key the user wants. This is also beneficial for people who also just want to put console to a separate key.
  • Non-BACKQUOTE keys however requires the root menu to handle the key and toggleconsole itself, whereas BACKQUOTE key will always envoke. The root menu will handle it if it's active without a console opened. Otherwise the engine will envoke it even for non-BACKQUOTE itself if you're in-game without the root menu opened or the console is already opened.
  • Nevra, who uses FR AZERTY confirmed this works well for him

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

* To workaround console not working for non-` key layouts, allow the
  rebinding of the console to any key the user wants. This is also
  beneficial for people who also just want to put console to a separate
  key.
* Non-` keys however requires the root menu to handle the key and
  toggleconsole itself, whereas ` key will always envoke. The root menu
  will handle it if it's active without a console opened. Otherwise the
  engine will envoke it even for non-` itself if you're in-game without
  the root menu opened or the console is already opened.
* fixes NeotokyoRebuild#620
@nullsystem nullsystem marked this pull request as ready for review September 22, 2024 17:30
@nullsystem nullsystem requested a review from a team September 22, 2024 17:59
@nullsystem nullsystem added Release priority Pull request is a priority for the next release bug labels Sep 22, 2024
@AdamTadeusz
Copy link
Copy Markdown
Contributor

Can't toggle the console off with a rebound key under any situation, in menu, in game or in game with the menu open.

Neither is this possible when using "bind x toggleconsole" originally however so I'm guessing this is something that can't be fixed?

@nullsystem
Copy link
Copy Markdown
Collaborator Author

nullsystem commented Sep 24, 2024

@AdamTadeusz I think it depends on what key you rebind. For example F5 worked well but "\" just relays to the console. In this case not much that can be done since the console out of our control, but it's good enough to workaround "`" issue.

@nullsystem nullsystem requested a review from a team September 24, 2024 19:41
@nullsystem nullsystem merged commit 040f01b into NeotokyoRebuild:master Sep 25, 2024
@nullsystem nullsystem added this to the v8.2-prealpha milestone Sep 25, 2024
@nullsystem nullsystem deleted the GH-620_ConsoleJank branch May 7, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release priority Pull request is a priority for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeoUI Console - Improve keybind fix

3 participants