NeoUI - Console toggle key rebind, intended for non-` key layouts#636
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Sep 25, 2024
Merged
Conversation
* To workaround console not working for non-` key layouts, allow the rebinding of the console to any key the user wants. This is also beneficial for people who also just want to put console to a separate key. * Non-` keys however requires the root menu to handle the key and toggleconsole itself, whereas ` key will always envoke. The root menu will handle it if it's active without a console opened. Otherwise the engine will envoke it even for non-` itself if you're in-game without the root menu opened or the console is already opened. * fixes NeotokyoRebuild#620
Contributor
|
Can't toggle the console off with a rebound key under any situation, in menu, in game or in game with the menu open. Neither is this possible when using "bind x toggleconsole" originally however so I'm guessing this is something that can't be fixed? |
AdamTadeusz
approved these changes
Sep 24, 2024
Collaborator
Author
|
@AdamTadeusz I think it depends on what key you rebind. For example F5 worked well but "\" just relays to the console. In this case not much that can be done since the console out of our control, but it's good enough to workaround "`" issue. |
brysondev
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Toolchain
Linked Issues