Skip to content

Tony Sergi fixes integrations part 2 - networked animations#653

Merged
AdamTadeusz merged 19 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:030_TonySergiFixesChangesIntegrationPart2
Oct 12, 2024
Merged

Tony Sergi fixes integrations part 2 - networked animations#653
AdamTadeusz merged 19 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:030_TonySergiFixesChangesIntegrationPart2

Conversation

@AdamTadeusz
Copy link
Copy Markdown
Contributor

@AdamTadeusz AdamTadeusz commented Sep 28, 2024

Description

Adds Tony Sergi's multiplayer_animstate.

Decided to drop neo_playeranimstate, hl2mp_playeranimstate does not differ that much from what we need for the neo player, but can revert it and multiplayer_animstate and put all the changes into neo_playeranimstate instead.

For the reviewers, unless you do not trust Tony Sergi's changes, I suggest clicking on the commit that he authored and marking all the changes there as read separately, should cut down on the amount of changes needed to be reviewed significantly.

[Edit] actually it seems that commit also contains my conflict resolutions so that won't work :(.

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz AdamTadeusz marked this pull request as draft September 28, 2024 15:03
@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

Still need to do some cleanup, should probably repurpose the old neo_playeranimstate to now includde the changes in hl2mp_playeranimstate and multiplayer_playeranimstate

@AdamTadeusz AdamTadeusz marked this pull request as ready for review September 29, 2024 14:25
@AdamTadeusz AdamTadeusz requested a review from a team September 29, 2024 14:25
Copy link
Copy Markdown
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'd like a proper test with lag compensation. EU host and we run through all the animations.

fakelag be damned I wanna see this forreal

@brysondev
Copy link
Copy Markdown
Contributor

Still some animation looping issues with assault's head and grenade idle animations appear to be playing faster than they should.

@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

Still some animation looping issues with assault's head and grenade idle animations appear to be playing faster than they should.

If you look at the animations in half life model viewer they do actually do those head movements. I think it's just a case of the upper body animations being slower in the original than they are currently in this branch, or maybe its tied to the player speed or something.

@AdamTadeusz AdamTadeusz requested review from a team and brysondev October 3, 2024 13:57
brysondev
brysondev previously approved these changes Oct 4, 2024
@nullsystem nullsystem added this to the v9.0-prealpha milestone Oct 8, 2024
@AdamTadeusz AdamTadeusz requested a review from a team October 9, 2024 06:53
Masterkatze
Masterkatze previously approved these changes Oct 12, 2024
@AdamTadeusz AdamTadeusz dismissed stale reviews from Masterkatze and brysondev via bc999bd October 12, 2024 14:03
Copy link
Copy Markdown
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AdamTadeusz AdamTadeusz merged commit e275fe2 into NeotokyoRebuild:master Oct 12, 2024
@AdamTadeusz AdamTadeusz deleted the 030_TonySergiFixesChangesIntegrationPart2 branch January 24, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants