Add ready up mechanic to start a match, allow non-auto-intermission#680
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Oct 12, 2024
Merged
Conversation
c02fd71 to
113d259
Compare
113d259 to
885b932
Compare
brysondev
previously approved these changes
Oct 9, 2024
AdamTadeusz
previously approved these changes
Oct 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
885b932 to
582872d
Compare
Collaborator
Author
Functionality wise it's quite different at the moment even if it serves similar purpose. |
AdamTadeusz
previously approved these changes
Oct 12, 2024
Contributor
|
@nullsystem conflicts |
brysondev
previously approved these changes
Oct 12, 2024
Contributor
brysondev
left a comment
There was a problem hiding this comment.
Definitely wanna adjust chat commands a little but that can be a separate PR.
* A (not enabled by default) ready up mechanic that will only start a
game if the players ready match the defined threshold (default to
5v5)
* Allows to override the limit if desired, although for either scenarios
will still require equal amount of players between Jinrai and NSF
* New native player commands to set/unset ready state, configure
override limit, and check players not ready
* The override limit will reset to false when players drops below threshold
* Automatic intermission can be turned off with the ready-up feature on
* HUD round state fixed to just directly take the const wchar_t strings
and therefore no need for ANSI->WCHAR conversions
* Make sure round wins and XPs are resetting on non-intermission to ready
* Only functional during idle state, other state shouldn't be able to
interact or/and activate ready-up feature
* Player commands
* !ready - For the player to signal they're ready to play
* !unready - For the player to signal they're not ready to play
* !overridelimit - A player to signal in behalf of everyone that
they'll be playing over the stated limit
* !playersnotready - Prints the players that are not ready and give
info on why it's not starting
* ConVars
* neo_sv_readyup_lobby - 0 by default, toggles the ready-up feature
* neo_sv_readyup_teamplayersthres - 5 by default, the exact amount
of players to ready-up and participate to start a game
* neo_sv_readyup_skipwarmup - 1 by default, if ready-up feature is
on and this is enabled, skip warmup state
* neo_sv_readyup_autointermission - 0 by default, if disabled will
not automatically enter intermission when the match ends
* fixes NeotokyoRebuild#218
d93bbd3
582872d to
d93bbd3
Compare
brysondev
approved these changes
Oct 12, 2024
AdamTadeusz
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Toolchain
Linked Issues