Skip to content

Motion Thermal Shader changes#685

Merged
AdamTadeusz merged 5 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:068_shadersMotionThermal
Oct 12, 2024
Merged

Motion Thermal Shader changes#685
AdamTadeusz merged 5 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:068_shadersMotionThermal

Conversation

@AdamTadeusz
Copy link
Copy Markdown
Contributor

@AdamTadeusz AdamTadeusz commented Oct 8, 2024

Description

New assets (compiled shaders. materials) in NeotokyoRebuild/neoAssets#8

Still not quite parity, but pretty much there. Thermal model shader looks correct on viewmodel but is off for other players, motion vision model shader, and the fullscreen shader itself are missing that red hue, motion model shader also missing opacity at low speeds

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Oct 8, 2024
@nullsystem nullsystem added this to the v9.0-prealpha milestone Oct 8, 2024
@Rainyan Rainyan self-requested a review October 9, 2024 08:37
Comment thread mp/src/materialsystem/stdshaders/fxctmp9/neo_motion_model_vs20.inc
Comment thread mp/src/materialsystem/stdshaders/fxctmp9/neo_thermal_model_vs20.inc
Comment thread mp/src/materialsystem/stdshaders/fxctmp9/neo_thermal_model_vs20.inc
Comment thread mp/src/materialsystem/stdshaders/fxctmp9/neo_thermal_model_vs20.inc
Comment thread mp/src/materialsystem/stdshaders/neo_motion_model_dx9_helper.cpp
Comment thread mp/src/materialsystem/stdshaders/neo_motion_model_dx9_helper.cpp
Comment thread mp/src/materialsystem/stdshaders/neo_thermal_model_dx9_helper.cpp
Comment thread mp/src/materialsystem/stdshaders/neo_thermal_model_dx9_helper.cpp
Comment thread mp/src/materialsystem/stdshaders/neo_thermal_model_dx9_helper.h
Comment thread mp/src/materialsystem/stdshaders/neo_motion_model_dx9_helper.h
@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

@Rainyan I can implement all these suggestions, but they are all like it is currently in the example files provided

@Rainyan
Copy link
Copy Markdown
Member

Rainyan commented Oct 11, 2024

@Rainyan I can implement all these suggestions, but they are all like it is currently in the example files provided

Ok np, if this is how Valve have it in their stuff then I'm ok to accept as-is

@Rainyan Rainyan self-requested a review October 11, 2024 16:40
@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

Sorry for making you read through all that stuff, I should have made it clear where the files originated from. I probably wasted a lot of your time I'm really sorry about that

@Rainyan Rainyan requested a review from a team October 11, 2024 16:41
@AdamTadeusz
Copy link
Copy Markdown
Contributor Author

image

@Rainyan
Copy link
Copy Markdown
Member

Rainyan commented Oct 11, 2024

Sorry for making you read through all that stuff, I should have made it clear where the files originated from. I probably wasted a lot of your time I'm really sorry about that

No worries. Thanks for all the shader work recently, good stuff

@AdamTadeusz AdamTadeusz merged commit 9d368e9 into NeotokyoRebuild:master Oct 12, 2024
@StellaNova522
Copy link
Copy Markdown

StellaNova522 commented Oct 23, 2024

Doing a smaller playtest since i missed the one 2 weeks ago, Visions looking really good but the Thermal vision is very hard to use on certain maps like fleshworld, some props and some walls are impossible to see and i think it needs a bit more tweaking to make things more clear, having to toggle thermals off to actually the map around you feels odd.

@AdamTadeusz AdamTadeusz deleted the 068_shadersMotionThermal branch January 24, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants