Refract cloak#693
Merged
AdamTadeusz merged 12 commits intoNeotokyoRebuild:masterfrom Oct 12, 2024
Merged
Conversation
AdamTadeusz
added
Changes in neoAssets
brysondev
previously approved these changes
Oct 12, 2024
Rainyan
previously approved these changes
Oct 12, 2024
Member
Rainyan
left a comment
Rainyan
left a comment
There was a problem hiding this comment.
LGTM, left some notes but I'd be happy to merge this
brysondev
previously approved these changes
Oct 12, 2024
Rainyan
requested changes
Oct 12, 2024
Rainyan
approved these changes
Oct 12, 2024
brysondev
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
----> New Material in NeotokyoRebuild/neoAssets#9 Improves cloak visuals <-----
Also hardcoded values in the PR assume the above new material is used.
This PR makes the original refract cloak effect work properly, as well as change the behavior of when player and weapon shadows and models themselves are drawn, to achieve almost the same effect as in the original. Some values like cloak strength increase with distance, rate of strength increase, cloak strength when moving vs standing still and cloak tint still need to be adjusted to get Parity. Also non-active weapons attached to players in this PR are significantly less visible compared to their og counterparts. Need to figure out whether the original behavior was a bug or whether it should be mimicked
Also thank you to @VantoNortim for figuring out how to cloak player weapons drawn with InternalDraw.
Link to his PR #665 . #665 as well as #673 are probably not compatible, I've moved around some of the logic to minimise unnecessary drawing of models and also how they behave with the vision modes. I would close those PRs if people are happy with this one, and am happy to consider @VantoNortim as a co-author of #693 instead
Toolchain
Linked Issues