feat: remove @open-wc/testing dependency#8
Merged
cristinecula merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
cristinecula
force-pushed
the
feature/neo-930-neovicitesting-renderhook
branch
from
703f9fa to
7753a9d
Compare
Replace litFixtureSync and waitUntil from @open-wc/testing with local implementations to enable Vitest compatibility. Changes: - Add src/wait-until.ts with waitUntil cloned from @open-wc/testing-helpers - Export waitUntil from package for external use - Replace litFixtureSync with lit-html render() + DOM container - Update test to use @esm-bundle/chai directly - Add skipLibCheck for chai type compatibility - Update @neovici/cfg to ^2.8.0 for check-duplicate-components This removes the @open-wc/testing dependency which has ESM issues in jsdom environments, allowing the package to work with Vitest.
cristinecula
force-pushed
the
feature/neo-930-neovicitesting-renderhook
branch
from
7753a9d to
4e42eb8
Compare
cristinecula
changed the title
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@open-wc/testingdependency to enable Vitest compatibilitywaitUntilutility (cloned from@open-wc/testing-helpers) and exports it from the packagelitFixtureSyncwith lit-html's nativerenderfunctionChanges
src/wait-until.tswaitUntilcloned from@open-wc/testing-helperssrc/index.tswaitUntilfrom packagesrc/renderer.tslitFixtureSyncwith lit-htmlrender()+ DOM containersrc/render-hook.tswaitUntilfrom local./wait-untilpackage.json@open-wc/testing, add@esm-bundle/chaito devDeps, update@neovici/cfgto^2.8.0test/render-hook.test.tsexpectfrom@esm-bundle/chaidirectlytsconfig.jsonskipLibCheck: truefor chai type compatibilityMotivation
The
@open-wc/testingpackage has ESM/extension issues in jsdom environments, preventing@neovici/testingfrom being used with Vitest. This change removes the problematic dependency while maintaining full backward compatibility.Related