Skip to content

Lyrics transcriber fix#474

Merged
NeptuneHub merged 5 commits intomainfrom
devel
May 1, 2026
Merged

Lyrics transcriber fix#474
NeptuneHub merged 5 commits intomainfrom
devel

Conversation

@NeptuneHub
Copy link
Copy Markdown
Owner

@NeptuneHub NeptuneHub commented May 1, 2026

This PR is mainly focused on Lyrics in order to remove the API call harcoded.
Lyrics will be computed with Whisper.

other mini fix was added in this pr like dashboard fix and provider migration fix

Co-authored-by: Copilot <copilot@github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the application version to v1.1.0 and updates Docker Compose configurations to use a broader build context. Remote lyric fetching has been disabled by stubbing out the provider functions, and the dashboard now displays indexing percentages with one decimal place of precision. In the provider migration template, the session ID retrieval was refactored to use a data attribute. Review feedback suggests explicitly defining the Dockerfile in the compose configuration for consistency and recommends refactoring the lyric fetching caller logic to avoid redundant processing now that providers are disabled.

Comment thread deployment/test/docker-compose-nvidia-test.yaml
Comment thread lyrics/lyrics_transcriber.py
NeptuneHub and others added 4 commits May 2, 2026 00:09
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@NeptuneHub NeptuneHub merged commit 4ee763a into main May 1, 2026
18 checks passed
@NeptuneHub NeptuneHub deleted the devel branch May 1, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant