Lyrics transcriber fix#474
Merged
NeptuneHub merged 5 commits intomainfrom May 1, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request increments the application version to v1.1.0 and updates Docker Compose configurations to use a broader build context. Remote lyric fetching has been disabled by stubbing out the provider functions, and the dashboard now displays indexing percentages with one decimal place of precision. In the provider migration template, the session ID retrieval was refactored to use a data attribute. Review feedback suggests explicitly defining the Dockerfile in the compose configuration for consistency and recommends refactoring the lyric fetching caller logic to avoid redundant processing now that providers are disabled.
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly focused on Lyrics in order to remove the API call harcoded.
Lyrics will be computed with Whisper.
other mini fix was added in this pr like dashboard fix and provider migration fix