Lyrics API optional setup#475
Conversation
Co-authored-by: Copilot <copilot@github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a user-configurable lyrics API system, enabling the definition of two external API slots for fetching lyrics prior to local Whisper transcription. It includes a new setup wizard interface for analyzing example URLs to auto-detect parameters and JSON fields, alongside backend updates to handle dynamic requests and environment adjustments to disable HuggingFace XetHub transport. Feedback focuses on enhancing the security and robustness of the API interaction logic, specifically recommending stronger SSRF protection, the addition of standard User-Agent headers, safer handling of configuration values to prevent potential AttributeError exceptions, and dynamic character set detection for API responses.
…uest forgery' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… through an exception' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
2 participants
This PR enable the possibility to configure lyrics API. The idea is leave the user to bring is own API by putting an example of API call.
It actually support: