Persist 'nullified' death bans and add DB support#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nullifiedso history is preserved and consumers can treat them differently.Description
nullifiedboolean toBanwith constructors,isNullified/setNullified, and include it inserializeandDeserialize.banTime == 0inPlayerData, mark itnullified, and still add/remove it from server data and update the player repository.ServerData, setnullifiedtotrueon the ban before removing.MySQLBanMapperto detect whether thenullifiedcolumn exists, include it in the generated INSERT/UPDATE SQL and parameter binding, and safely readnullifiedfrom result sets for backward compatibility; updatedbsetup.sqlto add thenullifiedcolumn with default0.Testing
nullifiedcolumn to verify detection and backward-compatible reads succeeded.Codex Task