Skip to content

Sampling window: model-specific defaults and entry fields#1290

Merged
dxqb merged 8 commits intoNerogar:mergefrom
O-J1:presets_setup_sampling
Mar 1, 2026
Merged

Sampling window: model-specific defaults and entry fields#1290
dxqb merged 8 commits intoNerogar:mergefrom
O-J1:presets_setup_sampling

Conversation

@O-J1
Copy link
Copy Markdown
Collaborator

@O-J1 O-J1 commented Feb 6, 2026

  1. Hide scheduler aka sampler for flowmatching models as its ignored by them
  2. Hide video fields for image models
  3. Hide inpainting fields where not an inpainting model
  4. Add cfg, steps, width, height and negative prompt to SampleConfig based on model type. Ensuring we dont screw users over from the start. Only Chroma utilises a negative prompt currently.
image

@dxqb
Copy link
Copy Markdown
Collaborator

dxqb commented Feb 6, 2026

Thanks!
Does it address all of #958?
Linking then

@dxqb dxqb linked an issue Feb 6, 2026 that may be closed by this pull request
3 tasks
@O-J1
Copy link
Copy Markdown
Collaborator Author

O-J1 commented Feb 6, 2026

Thanks! Does it address all of #958? Linking then

Yes, actually I forgot to mention it also only shows inpainting fields for inpainting models. So it covers everything

@O-J1 O-J1 marked this pull request as ready for review February 12, 2026 17:10
Copy link
Copy Markdown
Collaborator

@dxqb dxqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only minor comments

Comment thread modules/ui/SampleFrame.py
Comment thread modules/ui/SampleFrame.py Outdated
@dxqb
Copy link
Copy Markdown
Collaborator

dxqb commented Mar 1, 2026

👀

@O-J1 O-J1 added the merging last steps before merge label Mar 1, 2026
@dxqb dxqb changed the base branch from master to merge March 1, 2026 13:14
@dxqb dxqb changed the title Fix longstanding sampling window issues Sampling window: model-specific defaults and entry fields Mar 1, 2026
@dxqb dxqb merged commit e0496f8 into Nerogar:merge Mar 1, 2026
1 check passed
@O-J1 O-J1 deleted the presets_setup_sampling branch March 8, 2026 10:15
@O-J1 O-J1 restored the presets_setup_sampling branch March 8, 2026 10:15
@O-J1 O-J1 deleted the presets_setup_sampling branch March 8, 2026 10:16
@yang-0201
Copy link
Copy Markdown

AttributeError: module 'modules.util.ui.components' has no attribute 'file_entry'
When switching to Flux Fill LoRA, this error occurs in the sampling window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merging last steps before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Sampling window

3 participants