Skip to content

feat: phase 5.2 — accessible modals, focus restoration, translatable a11y labels#151

Merged
NesiciCoding merged 2 commits into
mainfrom
worktree-agent-a27b82c2fb24dd727
Jun 20, 2026
Merged

feat: phase 5.2 — accessible modals, focus restoration, translatable a11y labels#151
NesiciCoding merged 2 commits into
mainfrom
worktree-agent-a27b82c2fb24dd727

Conversation

@NesiciCoding

Copy link
Copy Markdown
Owner

Part of Phase 5 (UI/UX Polish) — sub-phase 5.2 WCAG AAA, interaction/focus side. (Contrast side shipped separately in #147.)

What

  • Routes the GradeStudent keyboard-shortcuts modal and the RubricBuilder markdown-hint + version-history modals through the shared Radix-backed Modal component → focus trap, focus restoration to the trigger on close, and Escape-to-close (previously hand-rolled overlays with no focus management).
  • Makes RubricBuilder drag-handle aria-labels translatable (rubricBuilder.drag_reorder_criterion / _level / untitled) — @hello-pangea/dnd already provides keyboard dragging.
  • i18n's the existing skip-to-content link (new a11y.skip_to_content key).
  • All new keys added to EN/NL/FR/DE/ES.

Notes

  • A global :focus-visible outline and the skip-nav link already existed in main, so those AAA targets were already met.
  • Deferred: adding RubricBuilder/GradeStudent/ComparativeGrading to the jest-axe page suite needs heavy provider/route mocking for those 1.7k–4k-line pages; tracked as a follow-up rather than risk brittle tests here.

Verification

  • npm run typecheck clean
  • npm run lint 0 errors (pre-existing warnings only)
  • npm test 1609 passed / 103 files, i18n parity green

🤖 Generated with Claude Code

…a11y labels

- Route GradeStudent (keyboard-shortcuts) and RubricBuilder (markdown hint,
  version history) ad-hoc modals through the shared Radix-backed Modal, which
  provides a focus trap, focus restoration to the trigger on close, and
  Escape-to-close.
- Make RubricBuilder drag-handle aria-labels translatable
  (rubricBuilder.drag_reorder_criterion / _level / untitled).
- i18n the existing skip-to-content link (new a11y.skip_to_content namespace).

All new keys added to EN/NL/FR/DE/ES.

Note: a global :focus-visible outline and the skip link already exist in main,
so AAA focus-ring and skip-nav targets were already satisfied.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@NesiciCoding, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 51 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b4734301-3c95-4410-a2d6-9d99ab16deeb

📥 Commits

Reviewing files that changed from the base of the PR and between 8e22387 and 811b854.

📒 Files selected for processing (8)
  • src/App.tsx
  • src/locales/de.json
  • src/locales/en.json
  • src/locales/es.json
  • src/locales/fr.json
  • src/locales/nl.json
  • src/pages/GradeStudent.tsx
  • src/pages/RubricBuilder.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-agent-a27b82c2fb24dd727

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 60.56% (🎯 52%) 4925 / 8132
🔵 Statements 59.33% (🎯 51%) 5603 / 9443
🔵 Functions 49.75% (🎯 42%) 1657 / 3330
🔵 Branches 51.48% (🎯 43%) 4110 / 7983
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/pages/GradeStudent.tsx 39.82% 36.62% 30% 40.89% 86, 87-93, 139, 141, 156, 166, 170-182, 193, 195, 198, 212-221, 225-240, 247, 255-300, 310-312, 320-321, 326-331, 337, 343-345, 352-356, 363-371, 377-382, 389, 394-396, 402, 404, 405, 406, 411-412, 419-420, 430-620, 677-684, 759-878, 1042-1161, 1197-1696
src/pages/RubricBuilder.tsx 13.8% 19.39% 6.68% 14.71% 72-79, 118, 168-175, 187, 202-204, 221-229, 233-249, 268-287, 294-341, 345-670, 685-897, 942-994, 1008, 1063-1134, 1188-1258, 1310-1592, 1630-1931, 2043-2209, 2306-3622, 3650-4317
Generated in workflow #513 for commit 6082e3a by the Vitest Coverage Report Action

…igger

The version-history panel is now a focus-trapping Radix dialog, which marks
the outside DOM aria-hidden — so re-clicking the trigger to toggle it closed
no longer works (the button leaves the accessibility tree). Close it with
Escape instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@NesiciCoding NesiciCoding merged commit 43acc1d into main Jun 20, 2026
7 checks passed
@NesiciCoding NesiciCoding deleted the worktree-agent-a27b82c2fb24dd727 branch June 20, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant