Skip to content

Conversation

@Raji-S
Copy link

@Raji-S Raji-S commented Jul 11, 2017

This PR is for showing labels at specific positions on the X and Y axis.
There's a special requirement to show labels at specific points on WiFi Channel Map chart. Without this change, displayed labels on the (x-axis) were random and not meaningful.

Note: These changes were taken from one of the pull request of MPAndroid chart.

@Raji-S Raji-S requested review from danbox, ewisor and jmorales4 July 11, 2017 19:53
Copy link

@ewisor ewisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You mentioned the changes are from a separate PR on the parent PhilJay/MPAndroidChart repo. Not from a another forked repo? Can you provide additional details/links to the original PR you used?

@Raji-S Raji-S merged commit a07152b into andromeda-0.2 Jul 11, 2017
@Raji-S
Copy link
Author

Raji-S commented Jul 11, 2017

Merging code but accepting comments. I'll make changes based on suggestions if any.

@Raji-S Raji-S deleted the Show_Specific_Label_Positions branch August 15, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants