Feature/cstackex 183 pr#55
Merged
Merged
Conversation
- extracted the ONTAP plugin name to interface nane to use it from one place. - Corrected indentation gaps.
piyush5netapp
approved these changes
May 12, 2026
| } | ||
|
|
||
| if (StringUtils.isBlank(providerName)) { | ||
| if (StringUtils.isBlank(providerName )) { |
There was a problem hiding this comment.
Do we need space after argument ?
| public void setName(String name) {} | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; } |
There was a problem hiding this comment.
Closing braces should be in next line.
| if (values == null || values.isEmpty()) { | ||
| logger.error("getAccessGroup: get Igroup failed. Invalid request: {}", values); | ||
| throw new CloudRuntimeException(" get Igroup Failed, invalid request"); | ||
| throw new CloudRuntimeException("get Igroup Failed, invalid request"); |
suryag1201
reviewed
May 13, 2026
|
|
||
| if (jobResponse != null && jobResponse.getJob() != null) { | ||
| // Poll for job completion | ||
| Boolean jobSucceeded = storageStrategy.jobPollForSuccess(jobResponse.getJob().getUuid(), 30, 2); |
There was a problem hiding this comment.
we can put this some variable instead directly putting the 2000 value here
suryag1201
reviewed
May 13, 2026
|
|
||
| // Poll for job completion | ||
| Boolean jobSucceeded = storageStrategy.jobPollForSuccess(jobResponse.getJob().getUuid(), 30, 2); | ||
| Boolean jobSucceeded = storageStrategy.jobPollForSuccess(jobResponse.getJob().getUuid(), 30, 2000); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?