Conversation
There was a problem hiding this comment.
Pull request overview
Adds “Top users” visibility to the volume dashboard by introducing new Grafana panels and extending the RESTPerf VolumeTopClients plugin to collect/export per-volume top-user metrics.
Changes:
- Add a new collapsed “Users” row to the volume Grafana dashboard with panels for top users by read/write IOPs and throughput.
- Extend
volumetopmetrics(RESTPerf) to fetch/process/exportvolume_top_users_*metrics and add unit tests + fixtures. - Update example configuration comments to include the optional
userobject type.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| grafana/dashboards/cmode/volume.json | Adds “Users” row + panels querying volume_top_users_* metrics. |
| conf/restperf/9.12.0/volume.yaml | Documents user as an optional objects entry for the top-metrics plugin. |
| conf/keyperf/9.15.0/volume.yaml | Same documentation update for KeyPerf volume template. |
| conf/keyperf/9.11.1/volume.yaml | Same documentation update for KeyPerf volume template. |
| conf/keyperf/9.10.0/volume.yaml | Same documentation update for KeyPerf volume template. |
| cmd/collectors/restperf/plugins/volumetopmetrics/volumetopmetrics.go | Implements fetching/processing/exporting top-user metrics and enablement flag. |
| cmd/collectors/restperf/plugins/volumetopmetrics/volumetopmetrics_test.go | Adds tests for processing top-user metrics. |
| cmd/collectors/restperf/plugins/volumetopmetrics/testdata/user_readops.json | New fixture for top-user read IOPs. |
| cmd/collectors/restperf/plugins/volumetopmetrics/testdata/user_writeops.json | New fixture for top-user write IOPs. |
| cmd/collectors/restperf/plugins/volumetopmetrics/testdata/user_readdata.json | New fixture for top-user read throughput. |
| cmd/collectors/restperf/plugins/volumetopmetrics/testdata/user_writedata.json | New fixture for top-user write throughput. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | API | Endpoint | Metric | Template | | ||
| |--------|----------|--------|---------| | ||
| | RestPerf | `api/storage/volumes/*/top-metrics/clients` | `throughput.write`<br><span class="key">Unit:</span> <br><span class="key">Type:</span> <br><span class="key">Base:</span> | conf/restperf/9.12.0/volume.yaml | | ||
| | KeyPerf | `api/storage/volumes/*/top-metrics/files` | `throughput.write`<br><span class="key">Unit:</span> <br><span class="key">Type:</span> <br><span class="key">Base:</span> | conf/keyperf/9.15.0/volume.yaml | |
There was a problem hiding this comment.
The endpoint for volume_top_clients_write_data is incorrect. It currently shows "api/storage/volumes//top-metrics/files" but should be "api/storage/volumes//top-metrics/clients" since this metric is for top clients, not top files. This is a pre-existing bug but should be fixed since this file is being modified.
No description provided.