Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ONTAP license collection and a Grafana dashboard to surface license details via the REST collector.
Changes:
- Introduce a new REST
Licenseobject template and corresponding REST plugin to emitlicense_*metrics. - Add a new Grafana dashboard (
ONTAP: License) based on the new metrics. - Update generated metric metadata/docs and integration validation lists to include the new counters.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| mcp/metadata/ontap_metrics.json | Adds descriptions for new license_* metrics in MCP metadata. |
| integration/test/dashboard_json_test.go | Adds new license counters to the REST-only exclusion list for ZAPI validation. |
| grafana/dashboards/cmode/license.json | New Grafana dashboard for license visibility (table-based). |
| docs/storagegrid-metrics.md | Updates generated “Creation Date”. |
| docs/ontap-metrics.md | Updates generated “Creation Date”, adds links and new metric sections for license_*. |
| docs/eseries-metrics.md | Updates generated “Creation Date”. |
| docs/cisco-switch-metrics.md | Updates generated “Creation Date” and adds missing visualization reference for cisco_interface_up. |
| conf/rest/default.yaml | Registers the License REST object template. |
| conf/rest/9.12.0/license.yaml | New REST template for api/cluster/licensing/licenses + plugin hook. |
| cmd/tools/generate/counter.yaml | Adds new counters so docs/metadata generation includes license_*. |
| cmd/collectors/rest/rest.go | Wires in the new REST plugin module (License). |
| cmd/collectors/rest/plugins/license/license.go | New REST plugin that splits per-owner license info and derives capacity and expiry metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Mar 2, 2026
Hardikl
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.