feat: add port ip and host connection details#4196
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Harvest’s metric surface and dashboards to expose additional connection details (E-Series port IP/host-board inventory) and adds new ONTAP SnapMirror fabriclink counters, along with regenerated metrics documentation.
Changes:
- Add ONTAP SnapMirror fabriclink metrics (
snapmirror_fl_*) to metadata and docs. - Add E-Series IO module/host-board inventory metric (
eseries_host_board_labels) and update the E-Series Hardware Grafana dashboard to display it and includeip_addressfor host interfaces. - Update generated metrics documentation creation dates.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mcp/metadata/ontap_metrics.json | Adds new SnapMirror fabriclink metric descriptions. |
| mcp/metadata/eseries_metrics.json | Adds eseries_host_board_labels metric description. |
| grafana/dashboards/eseries/hardware.json | Updates dashboard to newer Grafana JSON shape; adds host interface IP and a new IO Module/Host Board row/panel. |
| docs/storagegrid-metrics.md | Updates generated docs creation date. |
| docs/ontap-metrics.md | Updates creation date; documents new SnapMirror fabriclink metrics. |
| docs/eseries-metrics.md | Updates creation date; documents new host-board metric and panel link. |
| docs/cisco-switch-metrics.md | Updates generated docs creation date. |
| cmd/tools/grafana/dashboard_test.go | Updates datasource validation to accept both legacy and new Grafana datasource JSON shapes. |
| cmd/tools/generate/eseries_counter.yaml | Registers eseries_host_board_labels in generated counter metadata. |
| cmd/collectors/eseries/plugins/hardware/host_board.go | New hardware plugin code to collect/export host-board inventory. |
| cmd/collectors/eseries/plugins/hardware/hardware.go | Wires host-board matrix init + processing into the hardware plugin. |
| cmd/collectors/eseries/plugins/hardware/controller.go | Adds ip_address label to host interface labels and extracts IP from API response shapes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Mar 16, 2026
Hardikl
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.