Skip to content

feat: add port ip and host connection details#4196

Merged
rahulguptajss merged 1 commit into
mainfrom
rg2-port-host
Mar 17, 2026
Merged

feat: add port ip and host connection details#4196
rahulguptajss merged 1 commit into
mainfrom
rg2-port-host

Conversation

@rahulguptajss
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 16, 2026 14:39
@cla-bot cla-bot Bot added the cla-signed label Mar 16, 2026
@rahulguptajss rahulguptajss linked an issue Mar 16, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Harvest’s metric surface and dashboards to expose additional connection details (E-Series port IP/host-board inventory) and adds new ONTAP SnapMirror fabriclink counters, along with regenerated metrics documentation.

Changes:

  • Add ONTAP SnapMirror fabriclink metrics (snapmirror_fl_*) to metadata and docs.
  • Add E-Series IO module/host-board inventory metric (eseries_host_board_labels) and update the E-Series Hardware Grafana dashboard to display it and include ip_address for host interfaces.
  • Update generated metrics documentation creation dates.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mcp/metadata/ontap_metrics.json Adds new SnapMirror fabriclink metric descriptions.
mcp/metadata/eseries_metrics.json Adds eseries_host_board_labels metric description.
grafana/dashboards/eseries/hardware.json Updates dashboard to newer Grafana JSON shape; adds host interface IP and a new IO Module/Host Board row/panel.
docs/storagegrid-metrics.md Updates generated docs creation date.
docs/ontap-metrics.md Updates creation date; documents new SnapMirror fabriclink metrics.
docs/eseries-metrics.md Updates creation date; documents new host-board metric and panel link.
docs/cisco-switch-metrics.md Updates generated docs creation date.
cmd/tools/grafana/dashboard_test.go Updates datasource validation to accept both legacy and new Grafana datasource JSON shapes.
cmd/tools/generate/eseries_counter.yaml Registers eseries_host_board_labels in generated counter metadata.
cmd/collectors/eseries/plugins/hardware/host_board.go New hardware plugin code to collect/export host-board inventory.
cmd/collectors/eseries/plugins/hardware/hardware.go Wires host-board matrix init + processing into the hardware plugin.
cmd/collectors/eseries/plugins/hardware/controller.go Adds ip_address label to host interface labels and extracts IP from API response shapes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/collectors/eseries/plugins/hardware/host_board.go
Comment thread cmd/collectors/eseries/plugins/hardware/controller.go
@rahulguptajss rahulguptajss merged commit 487b053 into main Mar 17, 2026
14 checks passed
@rahulguptajss rahulguptajss deleted the rg2-port-host branch March 17, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an E-Series collector

4 participants