Skip to content

feat: Do not auto-upgrade KeyPerf to RestPerf if RestPerf exists#4252

Merged
cgrinds merged 2 commits into
mainfrom
cbg-afx
Apr 29, 2026
Merged

feat: Do not auto-upgrade KeyPerf to RestPerf if RestPerf exists#4252
cgrinds merged 2 commits into
mainfrom
cbg-afx

Conversation

@cgrinds
Copy link
Copy Markdown
Collaborator

@cgrinds cgrinds commented Apr 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 14:21
@cla-bot cla-bot Bot added the cla-signed label Apr 29, 2026
Hardikl
Hardikl previously approved these changes Apr 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds REST performance capability detection to remote cluster discovery and uses it to prevent automatically replacing RestPerf with KeyPerf on disaggregated systems when RestPerf is actually available.

Changes:

  • Extend conf.Remote with a HasRESTPerf flag derived from a REST API probe.
  • Add HrefBuilder.ReturnRecords() to allow disabling record returns for capability checks.
  • Adjust collector upgrade logic and tests to preserve RestPerf when supported.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/conf/remotes.go Adds HasRESTPerf to Remote and sets it during REST-based remote creation.
cmd/tools/rest/href_builder.go Adds return_records configurability via a new builder option.
cmd/tools/rest/client.go Probes api/cluster/counter/tables to populate HasRESTPerf during UpdateClusterInfo.
cmd/poller/poller.go Updates upgrade logic to avoid RestPerfKeyPerf when HasRESTPerf is true.
cmd/poller/poller_test.go Adds test coverage for AFX/disaggregated behavior when HasRESTPerf is true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/tools/rest/client.go
Comment thread cmd/poller/poller.go Outdated
@cgrinds cgrinds merged commit 34eb04e into main Apr 29, 2026
20 checks passed
@cgrinds cgrinds deleted the cbg-afx branch April 29, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants