Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes EMS matrix-cache behavior when an EMS record is received for a message name but does not match any configured matches filters, ensuring the collector doesn’t retain an empty/invalid matrix entry that can interfere with later valid events.
Changes:
- Track whether an EMS matrix already existed vs. was newly created during
HandleResults. - When an EMS record does not match any configured props, remove the instance and additionally delete the matrix entry if it was newly created for that non-matching record.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
674
to
+678
| if !isMatch { | ||
| mx.RemoveInstance(instanceKey) | ||
| if !existingEms { | ||
| delete(m, msgName) | ||
| } |
rahulguptajss
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing,
Case 1: when below order ems generated in sub sequent polls, then first ems retained in global
e.Matrixcache and second is not valid so it won't add any new instance to existing matrix. No changes in this workflow.Case 2: when below order ems generated in sub sequent polls, then first ems is not valid and not matched and deleted from
e.Matrixand second is valid so added in globale.Matrixcache as-is. Fix is targeting this workflow.