feat: Enable clickable files, shares and tasks table rows to view det…#6
Merged
romdalf merged 6 commits intoNetApp:neo-v3from Dec 5, 2025
Merged
Conversation
Neo UI v3.0.4-1
Neo v3.0.4-2
fix build errors
…ails and prevent event propagation from nested actions. Add interactive sahding for positive feedback on hover.
Contributor
Author
|
@romdalf - UX Enhancements |
There was a problem hiding this comment.
Pull request overview
This PR enhances user experience in data tables by making table rows clickable to view details and fixing event propagation issues with action buttons. The implementation ensures that clicking on action buttons or dropdown menus doesn't trigger the row's click handler.
- Added clickable row functionality with visual feedback (cursor and hover states) to
FilesTable,SharesTable, andTasksTable - Implemented
stopPropagation()on action buttons to prevent unintended row click triggering - Bumped package version to
3.0.4-2and updated peer dependency flags in package-lock.json
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/data-tables/tasksT.tsx | Added row-level onClick handler for task details and stopPropagation on dropdown trigger button |
| src/components/data-tables/sharesT.tsx | Added row-level onClick handler for share details, stopPropagation on dropdown trigger, and code formatting improvements |
| src/components/data-tables/filesT.tsx | Added row-level onClick handler for file metadata and stopPropagation on the info button click handler |
| package-lock.json | Version bump to 3.0.4-2 and peer dependency flag updates for several packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the interactivity and usability of the data tables for files, shares, and tasks by making table rows clickable to show details and preventing event propagation issues with row action buttons. The changes ensure a more intuitive user experience when interacting with table rows and their associated actions.
Enhanced table row interactivity:
FilesTable,SharesTable, andTasksTableclickable to show metadata or details, and added visual feedback with pointer cursor and hover background styling. (src/components/data-tables/filesT.tsx[1]src/components/data-tables/sharesT.tsx[2]src/components/data-tables/tasksT.tsx[3]Improved event handling for action buttons:
src/components/data-tables/filesT.tsx[1]src/components/data-tables/sharesT.tsx[2]src/components/data-tables/tasksT.tsx[3]