Update CONTRIBUTING.md#749
Closed
juliantap wants to merge 2 commits into
Closed
Conversation
Updated the CCLA process per Tim Clayton-Luce. We also need to remove the CCLA PDF.
gnarl
suggested changes
Jul 27, 2022
Contributor
gnarl
left a comment
gnarl
left a comment
There was a problem hiding this comment.
@juliantap, just one change
Added Project Name and Project Website instructions.
Author
|
@gnarl I added the clarification for Name & Website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the CCLA process per Tim. We also need to remove the CCLA PDF.
Change description
Need to update the CCLA process per Tim.
Project tracking
n/a
Do any added TODOs have an issue in the backlog?
no
Did you add unit tests? Why not?
n/a
Does this code need functional testing?
no
Is a code review walkthrough needed? why or why not?
no
Should additional test coverage be executed in addition to pre-merge?
no
Does this code need a note in the changelog?
Maybe a note that CCLA process was updated.
Does this code require documentation changes?
Only if we decide to note the CCLA chance in changlog.md.
Additional Information
We also need to remove https://github.com/NetApp/trident/blob/master/CONTRIBUTING_CCLA.pdf from the repo.