Skip to content

refactor: remove ActiveDeveloper user flag#308

Merged
KubaZ2 merged 1 commit intoNetCordDev:alphafrom
kshitijanurag:alpha
Apr 1, 2026
Merged

refactor: remove ActiveDeveloper user flag#308
KubaZ2 merged 1 commit intoNetCordDev:alphafrom
kshitijanurag:alpha

Conversation

@kshitijanurag
Copy link
Copy Markdown
Contributor

@pastadudes
Copy link
Copy Markdown

lgtm

@Mewyk
Copy link
Copy Markdown

Mewyk commented Mar 31, 2026

This does not make sense to me. The PR you mentioned is only about their documentation entry which removes it from their documentation completely, not specific information about the removal from their API. So, why would we update the XML just to add a specific note?

If you are going to use AI to create PRs, please at least review them yourself first.

@kshitijanurag kshitijanurag changed the title docs: mark ActiveDeveloper badge as decommissioned in UserFlags summary refactor: remove ActiveDeveloper user flag Mar 31, 2026
@kshitijanurag
Copy link
Copy Markdown
Contributor Author

This does not make sense to me. The PR you mentioned is only about their documentation entry which removes it from their documentation completely, not specific information about the removal from their API. So, why would we update the XML just to add a specific note?

If you are going to use AI to create PRs, please at least review them yourself first.

Initially, I removed the enum. Although I wasn't sure whether it's better to add a remark in the XML or remove it completely because of the effect removing it could have on downstream users.

@Mewyk
Copy link
Copy Markdown

Mewyk commented Mar 31, 2026

PRs are not meant for uncertainty or rapid fire hope they hit or adjust based on rejection direction of others. You should have used issues first instead if you were uncertain instead of just guessing based on what your automated AI process found/said.

By default, this PR should have been rejected and closed.

@pastadudes
Copy link
Copy Markdown

on second thought why was it an xml doc comment?
isn't there an ObsoleteAttribute you can use to apply on methods and fields?
me personally i would have used it and make it fail on compile
or alternatively remove it

@github-actions
Copy link
Copy Markdown

The documentation preview is available at https://preview.netcord.dev/308.

@KubaZ2
Copy link
Copy Markdown
Member

KubaZ2 commented Apr 1, 2026

Thanks!

@KubaZ2 KubaZ2 merged commit c733ee1 into NetCordDev:alpha Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants