Use scikit-build and dispense with setup.py#77
Merged
StephenOman merged 6 commits intoNetHack-LE:mainfrom Mar 6, 2026
Merged
Conversation
jbcoe
force-pushed
the
jbcoe/scikit-build
branch
from
8ea0e3e to
6fb176d
Compare
heiner
reviewed
Feb 1, 2026
jbcoe
force-pushed
the
jbcoe/scikit-build
branch
from
dd1f17a to
e707177
Compare
Version number is now deduced from git tags.
jbcoe
force-pushed
the
jbcoe/scikit-build
branch
from
e707177 to
10a365a
Compare
heiner
approved these changes
Mar 5, 2026
Collaborator
heiner
left a comment
heiner
left a comment
There was a problem hiding this comment.
looks good
given the push for uv I suggest we dispense with external deps for building and rely on uv which has that feature ... built in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
The version number now comes from Git Tags.
Pure CMake builds (used for debugging build issues) will have a version number 0.0.0 unless specified.