Do not leave PMD interface "stopped"#1013
Merged
shinae-woo merged 1 commit intomasterfrom Aug 27, 2020
Merged
Conversation
If updating MTU or MAC address fails, the interface ends up remaining in "stopped" mode in the current code. Instead we must call `rte_eth_dev_start()` before returning to recover from failure.
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
- Coverage 55.96% 55.87% -0.09%
==========================================
Files 9 9
Lines 1165 1165
==========================================
- Hits 652 651 -1
- Misses 513 514 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If updating MTU or MAC address fails, the interface ends up remaining in"stopped" mode in the current code. Instead we must call
rte_eth_dev_start()before returning to recover from failure.