Skip to content

Make names pytest-friendly#520

Merged
justinemarie merged 1 commit intomasterfrom
add_pytest_support
Jun 13, 2017
Merged

Make names pytest-friendly#520
justinemarie merged 1 commit intomasterfrom
add_pytest_support

Conversation

@sangjinhan
Copy link
Copy Markdown
Member

In pytest, which is compatible with unittest.py that we currently use, names with Test... and test_... have special meanings. This PR renames such names to avoid interference.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2017

Codecov Report

Merging #520 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   64.97%   64.96%   -0.01%     
==========================================
  Files         198      198              
  Lines       12246    12246              
==========================================
- Hits         7957     7956       -1     
- Misses       4289     4290       +1
Impacted Files Coverage Δ
bessctl/test_samples.py 89.74% <100%> (ø) ⬆️
pybess/test_bess.py 100% <100%> (ø) ⬆️
bessctl/test_sugar.py 97.05% <100%> (ø) ⬆️
core/drivers/unix_socket.cc 85.04% <0%> (-0.94%) ⬇️
core/modules/queue.cc 60.9% <0%> (-0.91%) ⬇️
core/modules/flowgen.cc 74.07% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4402b0d...028ee1d. Read the comment docs.

@justinemarie
Copy link
Copy Markdown
Contributor

LGTM (although does anyone else just hate how pep8 adds absurd amounts of spacing around comments?)

@justinemarie justinemarie merged commit 866f141 into master Jun 13, 2017
@sangjinhan
Copy link
Copy Markdown
Member Author

selfcat
1deb87a10c64b08aa877c41e0bc905e1

@sangjinhan sangjinhan deleted the add_pytest_support branch June 13, 2017 23:48
@justinemarie
Copy link
Copy Markdown
Contributor

HEY NO!
I was spending all that time looking for a photo of my family's cat!!
image

@justinemarie
Copy link
Copy Markdown
Contributor

I am sorry to make you feel like you had to find your own cat :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants