Skip to content

allow module .so's to be symbolic links#605

Merged
sangjinhan merged 1 commit intoNetSys:masterfrom
aristanetworks:arista-module-symlinks
Sep 5, 2017
Merged

allow module .so's to be symbolic links#605
sangjinhan merged 1 commit intoNetSys:masterfrom
aristanetworks:arista-module-symlinks

Conversation

@nrdmao
Copy link
Copy Markdown
Contributor

@nrdmao nrdmao commented Aug 11, 2017

If libtool is used to build libraries, then come in the form of .so.0.0.1 for example and then the .so is linked to the version specific .so. With this commit, bessd can load such symlinks. I also added some
logging to add diagnostics on modules loaded and failure to load modules.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2017

Codecov Report

Merging #605 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   69.18%   69.19%   +<.01%     
==========================================
  Files         204      204              
  Lines       12984    12987       +3     
==========================================
+ Hits         8983     8986       +3     
  Misses       4001     4001
Impacted Files Coverage Δ
core/bessd.cc 68.75% <75%> (-0.04%) ⬇️
core/modules/flowgen.cc 74.07% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03dab10...613a42a. Read the comment docs.

@changlan
Copy link
Copy Markdown
Member

LGTM. Contributor License Agreement pending.

@sangjinhan sangjinhan merged commit e96fb57 into NetSys:master Sep 5, 2017
@sangjinhan
Copy link
Copy Markdown
Member

tumblr_mbtq4y62nc1qbe5pxo1_1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants