allow module .so's to be symbolic links#605
Merged
sangjinhan merged 1 commit intoNetSys:masterfrom Sep 5, 2017
aristanetworks:arista-module-symlinks
Merged
allow module .so's to be symbolic links#605sangjinhan merged 1 commit intoNetSys:masterfrom aristanetworks:arista-module-symlinks
sangjinhan merged 1 commit intoNetSys:masterfrom
aristanetworks:arista-module-symlinks
Conversation
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 69.18% 69.19% +<.01%
==========================================
Files 204 204
Lines 12984 12987 +3
==========================================
+ Hits 8983 8986 +3
Misses 4001 4001
Continue to review full report at Codecov.
|
barath
approved these changes
Aug 11, 2017
Member
|
LGTM. Contributor License Agreement pending. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If libtool is used to build libraries, then come in the form of .so.0.0.1 for example and then the .so is linked to the version specific .so. With this commit, bessd can load such symlinks. I also added some
logging to add diagnostics on modules loaded and failure to load modules.