Mark get_summary in measure.cc as thread safe#632
Merged
sangjinhan merged 1 commit intoNetSys:masterfrom Sep 5, 2017
Merged
Conversation
`get_summary` reads a value, and should be thread safe to execute (the values might be off though).
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 69.29% 69.27% -0.03%
==========================================
Files 204 204
Lines 13078 13078
==========================================
- Hits 9063 9060 -3
- Misses 4015 4018 +3
Continue to review full report at Codecov.
|
Contributor
|
Is it possible that the return value will not just be stale but total junk? |
Member
Author
|
My reading of the function was no -- things like number of packets, and size of packets will be correct. The histogram might report some inaccuracies, but they will be small. |
Contributor
|
Ok, LGTM in that case.
…On Mon, Sep 4, 2017 at 6:29 PM, Aurojit Panda ***@***.***> wrote:
My reading of the function was no -- things like number of packets, and
size of packets will be correct. The histogram might report some
inaccuracies, but they will be small.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#632 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAk7eqd9cQkPCYhHByIAzde_5onFddtQks5sfKPxgaJpZM4PMRB2>
.
|
barath
approved these changes
Sep 5, 2017
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_summaryreads a value, and should be thread safe to execute (thevalues might be off though).