Mapping a logical internal/external ports to actual bess gates in nat#907
Merged
sangjinhan merged 1 commit intomasterfrom May 8, 2019
Merged
Mapping a logical internal/external ports to actual bess gates in nat#907sangjinhan merged 1 commit intomasterfrom
sangjinhan merged 1 commit intomasterfrom
Conversation
Contributor
|
I think the examples in bessctl/conf will be outdated when this is merged. Can you, please, update them as well? Thank you. |
Member
Author
|
@nemethf Ohh, thank you for catching this. Will update! |
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
==========================================
+ Coverage 55.7% 55.78% +0.08%
==========================================
Files 9 9
Lines 1149 1149
==========================================
+ Hits 640 641 +1
+ Misses 509 508 -1
Continue to review full report at Codecov.
|
sangjinhan
approved these changes
May 7, 2019
In nat module, packet flows are looks like internal --> 0:nat:0 --> external (forward direction) external --> 1:nat:1 --> internal (reverse direction) This PR makes the bess gates are correspondint with the logical nat ports, 0 for internal, and 1 for external, so the new packet flows will looks like internal --> 0:nat:1 --> external (forward direction) external --> 1:nat:0 --> internal (reverse direction)
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nat module, packet flows are looks like
internal --> 0:nat:0 --> external (forward direction)
external --> 1:nat:1 --> internal (reverse direction)
This PR makes the bess gates are correspondint with the logical nat
ports, 0 for internal, and 1 for external, so the new packet flows will
looks like
internal --> 0:nat:1 --> external (forward direction)
external --> 1:nat:0 --> internal (reverse direction)