Skip to content

Do not build dpdk with fPIC options #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melvinw merged 1 commit into from
Aug 13, 2020
Merged

Do not build dpdk with fPIC options #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def cmd(cmd, quiet=False, shell=False):
kernel_release = cmd('uname -r', quiet=True).strip()

DPDK_DIR = '%s/%s' % (DEPS_DIR, DPDK_VER)
DPDK_CFLAGS = '"-g -w -fPIC"'
DPDK_CFLAGS = '"-g -w"'
Copy link
Copy Markdown
Collaborator

@chris3torek chris3torek May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might (on some systems that we don't really care about...?) need an explicit no-pic and/or no-pie option (eg -fno-PIE). It looks like there was a big mess of contradictory options introduced in various distributions back in 2016 or so. Should we have a build.py flag for this? That is, rather than hardcoding -fPIC or absence of -fPIC we could have an option to put something in.

We could perhaps even try to figure out the right flags, if any, automatically... If this works for Ubuntu 18 though, that's what we really care about and should be the default.

Copy link
Copy Markdown
Member Author

@shinae-woo shinae-woo May 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-fPIC doesn't work on "Ubuntu18 with gcc+8". And also, "Ubuntu18 with gcc+8" doesn't necessarily need an explicit no-pie option. For the older version of g++, yeap, we explicitly disable the no-pie sounds better option to overwrite the default as you said.

DPDK_CONFIG = '%s/build/.config' % DPDK_DIR

extra_libs = set()
Expand Down