Skip to content

[4.4] meson: fix bugs that prevent you from disabling dev docs#2882

Merged
andylemin merged 2 commits intobranch-netatalk-4-4from
rdmark-dev-docs-meson-4.4
Apr 14, 2026
Merged

[4.4] meson: fix bugs that prevent you from disabling dev docs#2882
andylemin merged 2 commits intobranch-netatalk-4-4from
rdmark-dev-docs-meson-4.4

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Apr 12, 2026

two silly mistakes introduced when first creating the developer docs build scripts made it so that they were always built regardles of meson options

Reported-by: Kilian Kempf

two silly mistakes introduced when first creating the developer docs
build scripts made it so that they were always built regardles of meson
options

Reported-by: Kilian Kempf <kilian@kfk-net.de>
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 12, 2026

🤖 Augment PR Summary

Summary: Fixes Meson doc build logic so developer docs can be disabled via -Dwith-docs.
Changes: Defaults build_dev_docs to false and correctly gates it on 'developer' being selected (and Doxygen being available), so the option now actually controls whether dev docs are built.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@rdmark rdmark requested a review from andylemin April 12, 2026 07:11
@sonarqubecloud
Copy link
Copy Markdown

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Apr 12, 2026

@andylemin with this I am proposing we cut a 4.4.2 release: we arguably have critical mass of useful patches in the stable branch! thoughts?

@andylemin andylemin merged commit c1776b6 into branch-netatalk-4-4 Apr 14, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants