This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Fix search on es7-persistence#170
Merged
v1r3n merged 1 commit intoNetflix:mainfrom Feb 1, 2023
BirknerAlex:es7
Merged
Conversation
v1r3n
approved these changes
Feb 1, 2023
6 tasks
|
Thanks, hope this can be released early as possible(I must use a local jar to workaround this) |
SimonMisencik
pushed a commit
to SimonMisencik/conductor-community
that referenced
this pull request
Feb 17, 2023
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Oct 23, 2023
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Currently when using the es7-persistence index plugin no workflows will be returned from the search since the query to Elasticsearch isn't correct for ES7 and contains the deprecated
_typefield in the request URI.See also: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
Before the change the workflow query will be build something like:
After the change, the URL looks like:
The Elasticsearch _search API still supports the
_typesbut when indexing new objects the providedtypecan no longer be defined and will be ignored. All newly added documents do have the type_docnow and no longerworkflow.This change should be backwards compatible to existing documents when upgrading from ES6 to ES7.
I also added the plugin to the
gradle.buildfile and fixed the corresponding lock files as well. In my case it has worked to still include the upstreames6-persistenceplugin as well thees7-persistenceplugin.