fix: Sanitize Java keywords in generated client#911
Merged
jiholee17 merged 1 commit intoNetflix:masterfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
See the failure on pulpogato/pulpogato#841 for example |
rahulsom
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
...n-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/ClientApiGenerator.kt
Outdated
Show resolved
Hide resolved
...n-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/ClientApiGenerator.kt
Outdated
Show resolved
Hide resolved
...n-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/ClientApiGenerator.kt
Outdated
Show resolved
Hide resolved
sjohnr
reviewed
Jan 6, 2026
...n-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/ClientApiGenerator.kt
Outdated
Show resolved
Hide resolved
rahulsom
force-pushed
the
handle-java-keywords
branch
2 times, most recently
from
7745ac2 to
f19b2ec
Compare
Contributor
Author
|
Thanks @iuliiasobolevska & @sjohnr for the review! Changes are in. |
jiholee17
reviewed
Jan 9, 2026
...n-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/ClientApiGenerator.kt
Outdated
Show resolved
Hide resolved
Prior to this change, the generated code would have the right name for the parameter but wrong name in the creation of InputArgument.
```java
InputArgument packageArg = new InputArgument("package", package, false, null);
```
Now we have a test for generated code being compilable, and we handle this case correctly.
rahulsom
force-pushed
the
handle-java-keywords
branch
from
f19b2ec to
a1c7ba8
Compare
jiholee17
approved these changes
Jan 28, 2026
Contributor
Author
|
@jiholee17 Are we good to merge this? |
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the generated code would have the right name for the parameter but wrong name in the creation of InputArgument.
Now we have a test for generated code being compilable, and we handle this case correctly.