Can't get child fetcher to be invoked

[jgsmarques]

Hi all,

I'm trying to follow the demos on the documentation, and so far I have the same schema as the demo, and a simple class that provides the fetchers:

schema.graphqls

type Show {
  # The showId may or may not be there, depending on the scenario.
  showId: ID
  title: String
  reviews: [Review]
}

type Review {
  starRating: Int
}

ClientDataFetcher

@DgsComponent
public class ClientDataFetcher {
  private final List<Show> shows = Arrays.asList(
      new Show("1", "Stranger Things", null),
      new Show("2", "Ozark", null)
  );

  private final List<Review> reviews = Arrays.asList(
      new Review(1),
      new Review(2),
      new Review(3)
  );

  @DgsData(parentType = "Query", field = "shows")
  public List<Show> shows(@InputArgument("titleFilter") String titleFilter) {
    if(titleFilter == null) {
      return shows;
    }

    return shows.stream().filter(s -> s.getTitle().contains(titleFilter)).collect(Collectors.toList());
  }

  @DgsData(parentType = "Show", field = "reviews")
  List<Review> reviews(DgsDataFetchingEnvironment dfe) {
    Show show = dfe.getSource();
    return reviews;
  }
}

When running the application, I can make the following query

{
  shows {
    showId
    title
    reviews {
      starRating
    }
  }
}

and I get the following result

{
  "data": {
    "shows": [
      {
        "showId": "1",
        "title": "Stranger Things",
        "reviews": null
      },
      {
        "showId": "2",
        "title": "Ozark",
        "reviews": null
      }
    ]
  }
}

When debugging, the execution never passes through the method reviews. Can you please point me in the right direction?
I'm using version 3.8.2 of graphql-dgs-spring-boot-starter but I've tried with 3.9.3 with the same result.

Thank you!

[jgsmarques]

Just figured it out, I was missing the public modifier in the reviews method!
Thanks!

[GrantGochnauer]

Thank you for this! I ran into the EXACT same problem.

[jgsmarques]

This might actually be a bug in the documentation:
https://netflix.github.io/dgs/datafetching/
There are no public modifiers in the examples which can be misleading.

[GrantGochnauer]

Yes - good catch! And I was following along with the documentation which is why I copied it exactly.

[GrantGochnauer]

cc: @paulbakker

[srinivasankavitha]

Thanks for pointing this out. Will fix.

…

On Fri, Apr 9, 2021 at 8:42 AM Grant Gochnauer ***@***.***> wrote: cc: @paulbakker <https://github.com/paulbakker> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#192 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ5JPXIKAU27QD5DWKCDWG3TH4N6JANCNFSM4ZW272XQ> .

[srinivasankavitha]

Fixed by Netflix/dgs#27. On Fri, Apr 9, 2021 at 9:58 AM Kavitha Srinivasan ***@***.***> wrote:

…

Thanks for pointing this out. Will fix. On Fri, Apr 9, 2021 at 8:42 AM Grant Gochnauer ***@***.***> wrote: > cc: @paulbakker <https://github.com/paulbakker> > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#192 (reply in thread)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AJ5JPXIKAU27QD5DWKCDWG3TH4N6JANCNFSM4ZW272XQ> > . >

[GrantGochnauer]

thank you!