graphql-dgs-example-java-shared and graphql-dgs-example-java

[sbilello]

Hi everyone!

Would it make sense to keep the example self-contained without referencing the external module graphql-dgs-example-java-shared?

[paulbakker]

The reason for the split is so that we can run the same example code with different stacks: WebMVC and WebFlux, and in the near future graphql-spring. It makes it a little harder to navigate the examples, but it avoids the duplication we would otherwise get.

…

On Wed, Aug 4, 2021 at 5:19 PM Sergio Bilello ***@***.***> wrote: Hi everyone! Would it make sense to keep the example self-contained without referencing external modules the graphql-dgs-example-java? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#516>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2XLEVXHW4NAD7MLQOF5DT3HKKRANCNFSM5BSJ4MIQ> .

[sbilello]

The reason is pretty obvious.
I expect a developer that would grab just one of the modules to get familiar with the framework and would discover that it is missing some parts.
Readability and Isolation vs Code Duplication? :)

[berngp]

I think there is a point on calling them examples thought. Might be better to rename and point users to the following in the README file.

• https://github.com/Netflix/dgs-federation-example
• https://github.com/Netflix/dgs-examples-webflux
• https://github.com/Netflix/dgs-examples-java16
• https://github.com/Netflix/dgs-examples-webflux
• https://github.com/Netflix/dgs-examples-java
• https://github.com/Netflix/dgs-examples-kotlin

[paulbakker]

Yeah good point - the "examples" in the main repo aren't really user-focussed, but I can see how that's not obvious.