Make all timer threads daemonic in subscription handlers#1811
Merged
Conversation
Make sure all the Timer instances use daemonic threads so they don't block JVM shutdown, and add a PreDestroy method to the implementations to proactively clean up the session watchdog Timer. Additionally, add a descriptive name to each Timer instance.
Contributor
|
Should we uncomment the subscription tests as well to see if this fixes the hanging tests? |
srinivasankavitha
approved these changes
Feb 6, 2024
Member
Author
Actually, the only disabled tests I can find are from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all the Timer instances use daemonic threads so they don't block JVM shutdown, and add a PreDestroy method to the implementations to proactively clean up the session watchdog Timer. Additionally, add a descriptive name to each Timer instance.