Memory Fixes#25
Merged
Merged
Conversation
Caleb-An
commented
Oct 7, 2019
Caleb-An
commented
- Reject HTTP requests with an invalid (e.g. negative) Content-Length header value.
- Make sure to allocate enough memory in buffers for the operations they are used for, and to check/enforce buffer sizes when performing those memory operations.
- Properly allocate and free memory.
- Make a best effort at allocating memory for the network hardware address (remove code for Apple platforms).
- Try to consume all of the remaining content if a valid Content-Length header was provided.
- Check for success when attempting to acquire mutexes.
…eader value. Make sure to allocate enough memory in buffers for the operations they are used for, and to check/enforce buffer sizes when performing those memory operations. Properly allocate and free memory. Make a best effort at allocating memory for the network hardware address (remove code for Apple platforms). Try to consume all of the remaining content if a valid Content-Length header was provided. Check for success when attempting to acquire mutexes.
kemorrisnf
approved these changes
Oct 8, 2019
Contributor
kemorrisnf
left a comment
kemorrisnf
left a comment
There was a problem hiding this comment.
As discussed earlier, looks good.
yongjunj
added a commit
to yongjunj/dial-reference
that referenced
this pull request
Sep 18, 2020
don't clear app->dial_data again after setting it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.