This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(signal): keep existing filters on signal update #5973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates two endpoints to update the signal defintion, one that allows the signal filters (snooze, deduplication) to be overwritten (a new endpoint just for the UI), and one that only allows addition of new signal filters (the existing endpoint). It also fixes a discrepancy with the cli check that wouldn't allow a database init and restore if the db didn't previously exist.