add is_collection parameter to force corresponding serialization#239
Merged
shishirmk merged 3 commits intoNetflix:devfrom Jul 4, 2018
Merged
add is_collection parameter to force corresponding serialization#239shishirmk merged 3 commits intoNetflix:devfrom
shishirmk merged 3 commits intoNetflix:devfrom
Conversation
Collaborator
|
@ababich please add documentation that the user can pass in an optional key to force serialization as a collection. May be as part of this https://github.com/Netflix/fast_jsonapi#collection-serialization |
and notes re. default autodetect logic
Contributor
Author
|
Thanks for the documentation comment, just updated the PR |
Collaborator
|
@ababich sorry for the delay in getting back to you. This looks good. please fix the conflicts so that i can rebase and merge |
Contributor
Author
|
Hi! I'm in a travel mode now, but I believe merge was done properly, thanks! |
ababich
added a commit
to ababich/fast_jsonapi
that referenced
this pull request
Jul 18, 2018
* upstream/master: (25 commits) bump up version to 1.3 Add README instructions for using sparse fieldsets Use record type instead of reflected record type Set the record type for inherited serializers Remove unused code Update spec with included documents with no explicitly given fields Allow the serializer to return sparse fieldsets Add proc shortcut use case to README Add spec for proc methods with optional arguments Allow passing procs with variable arguments when declaring an attribute add is_collection parameter to force corresponding serialization (Netflix#239) remove options param from Link class fix relationship id_hash method create link class make include_relationship? a public method and use it in get_included_records method move add_relationship to each class method make fetch_associated_object a public method on relationship class so it can be called from SerilizationCore class WIP all tests are passing, but still need to write tests for relationship class working on new relationship class ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #229 and generalize
is_collectionhandling for different DB toolkitsAlso, supports and includes improvement similar to #234
for autodetection