Skip to content

Better benchmarks using existing method #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli wants to merge 3 commits into from
Closed

Better benchmarks using existing method #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36bc7ac
correctly configure AMS
NullVoxPopuli Feb 21, 2018
f8f6c8c
unsubscribe from logger
NullVoxPopuli Feb 21, 2018
7e2d0d9
run benchmarks on travis
NullVoxPopuli Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ source 'https://rubygems.org'

# Specify your gem's dependencies in fast_jsonapi.gemspec
gemspec

gem 'oj_mimic_json'
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ GEM
nokogiri (1.8.1)
mini_portile2 (~> 2.3.0)
oj (3.4.0)
oj_mimic_json (1.0.1)
rack (2.0.3)
rack-test (0.8.2)
rack (>= 1.0, < 3)
Expand Down Expand Up @@ -108,6 +109,7 @@ DEPENDENCIES
jsonapi-rb (~> 0.5.0)
jsonapi-serializers (~> 1.0.0)
oj (~> 3.3)
oj_mimic_json
rspec (~> 3.5.0)
rspec-benchmark (~> 0.3.0)
skylight (~> 1.3)
Expand Down
13 changes: 8 additions & 5 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,23 @@
require 'rspec-benchmark'
require 'byebug'
require 'active_model_serializers'
require 'oj'
require 'jsonapi/serializable'
require 'jsonapi-serializers'
require 'oj'
require 'oj_mimic_json'

Dir[File.dirname(__FILE__) + '/shared/contexts/*.rb'].each {|file| require file }

RSpec.configure do |config|
config.include RSpec::Benchmark::Matchers
if ENV['TRAVIS'] == 'true' || ENV['TRAVIS'] == true
config.filter_run_excluding performance: true
end
# For the PR, show the benchmarks.
# if ENV['TRAVIS'] == 'true' || ENV['TRAVIS'] == true
# config.filter_run_excluding performance: true
# end
end

Oj.optimize_rails
ActiveModel::Serializer.config.adapter = :json_api
ActiveModel::Serializer.config.key_transform = :underscore
ActiveModel::Serializer.config.key_transform = :unaltered
ActiveModelSerializers.logger = ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new('/dev/null'))
ActiveSupport::Notifications.unsubscribe(ActiveModelSerializers::Logging::RENDER_EVENT)