Skip to content

Cleanup persistence APIs#1069

Merged
tgianos merged 4 commits intoNetflix:masterfrom
tgianos:agentConnectTimeout
Feb 4, 2021
Merged

Cleanup persistence APIs#1069
tgianos merged 4 commits intoNetflix:masterfrom
tgianos:agentConnectTimeout

Conversation

@tgianos
Copy link
Copy Markdown
Contributor

@tgianos tgianos commented Feb 4, 2021

Remove some leftover debt from v3 to v4 execution

Leftover debt from removal of V3 logic. No longer need to reference things like "getAgentJob..." as everything is an agent job now. That just adds confusion.

Remove unused APIs as well.
All jobs are V4 now. Would drop column but other schema changes may be needed and would rather batch them.
@tgianos tgianos added this to the 4.0.0 milestone Feb 4, 2021
@tgianos tgianos self-assigned this Feb 4, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 4, 2021

Coverage Status

Coverage increased (+0.007%) to 93.88% when pulling 35c41de on tgianos:agentConnectTimeout into eae5369 on Netflix:master.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1069 (35c41de) into master (eae5369) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1069      +/-   ##
============================================
- Coverage     90.93%   90.93%   -0.01%     
  Complexity     3606     3606              
============================================
  Files           451      451              
  Lines         13863    13862       -1     
  Branches        948      948              
============================================
- Hits          12607    12606       -1     
  Misses          839      839              
  Partials        417      417              
Impacted Files Coverage Δ Complexity Δ
...a/services/impl/jpa/JpaPersistenceServiceImpl.java 96.48% <100.00%> (ø) 232.00 <2.00> (ø)
...ix/genie/web/tasks/leader/AgentJobCleanupTask.java 98.03% <100.00%> (-0.04%) 19.00 <13.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae5369...35c41de. Read the comment docs.

@tgianos tgianos merged commit 7278792 into Netflix:master Feb 4, 2021
@tgianos tgianos deleted the agentConnectTimeout branch February 4, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants