jig misses required static transitive modules

[sormuras]

Combining the example from: https://github.com/Netflix/jig#run-a-published-module
and the source launcher example from: https://docs.junit.org/current/api/org.junit.start/module-summary.html
into java @junit.args --add-modules org.junit.start HelloTests.java
you'll see a lot of warnings on the console:

warning: unknown enum constant Status.STABLE
  reason: class file for org.apiguardian.api.API$Status not found
warning: unknown enum constant Status.EXPERIMENTAL
  reason: class file for org.apiguardian.api.API$Status not found
...
warning: unknown enum constant Status.STABLE
100 warnings
only showing the first 100 warnings, of 128 total; use -Xmaxwarns if you would like to see more
╷
└─ JUnit Jupiter ✔
   └─ HelloTests ✔
      └─ stringLength() ✔

This seems to be related to the requires static transitive org.apiguardian.api; directive in org.junit.start's module descriptor: https://github.com/junit-team/junit-framework/blob/869b15510fa69f6f4660007202a416027eb7eb5f/junit-start/src/main/java/module-info.java#L28

A work-around is to add org.apiguardian.api to the list of required roots when using jig. Like so:

jig \
  --add-requires org.junit.start@6.1.3 \
  --add-requires org.apiguardian.api@1.1.2 \
  --resolve-options module-path \
  --write-argfile junit.args

With that configuration, you'll get no more warnings at run-time:

java @junit.args --add-modules org.junit.start HelloTests.java                    
╷
└─ JUnit Jupiter ✔
   └─ HelloTests ✔
      └─ stringLength() ✔

Find an example using a local lib directory here: https://github.com/junit-team/junit-examples/tree/main/junit-source-launcher

[sormuras]

I still have to check the java source launcher in its modular mode, by adding a module-info.java and moving HelloTests.java into a (hello) package. With that in place, some command-line arguments might be moved to the source module descriptor and the actual execution command could boil down to: java @junit.args hello/HelloTests.java

[DanielThomas]

I've gone back and forth on the static contract a few times, and had landed on --module-source-path plus a resolution request for either module-path or module-source-path providing them to the compiler or to the resolved --module-path respectively, but I neglected the source launcher case.

I've added back a --compile-time flag as an explicit opt in to include static requirements for compilation. Available in 0.16.7.